chore(ubergen): make rosetta fixtures submodule aware#17438
chore(ubergen): make rosetta fixtures submodule aware#17438mergify[bot] merged 3 commits intoaws:masterfrom kaizencc:ubergen
Conversation
|
|
| const uberRosettaTargetDir = path.join(uberRosettaDir, library.shortName.replace(/-/g, '_')); | ||
| if (await fs.pathExists(packageRosettaDir)) { | ||
| await fs.copy(packageRosettaDir, uberRosettaDir, { | ||
| await fs.copy(packageRosettaDir, uberRosettaTargetDir, { |
There was a problem hiding this comment.
I think we probably need to make an exception for the core submodule, which gets moved to the ROOT of the monopackage, not placed in a submodule.
There was a problem hiding this comment.
Now the fixtures show up in the rosetta directory and the number of outstanding failures went from 1973 to 1722. Also validated that stack.AddTransform compiles along with a few other examples from the core module.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Currently ubergen bundles all fixtures into the same `rosetta` folder. This means that all fixtures in files called `default.ts-fixture` replace each other as they are found and vie to be the last `default.ts-fixture` standing in the `rosetta` folder. This causes unintended compiliation failures for `yarn rosetta:extract --compile` in projects that rely on ubergen, since they will be copied into the wrong `default.ts-fixture`. The solution here in jsii is to find fixtures based on submodules: aws/jsii#3131. This PR updates ubergen to construct the necessary subfolders in `rosetta` so that the expected submodule fixtures can be found. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
4 participants
Currently ubergen bundles all fixtures into the same
rosettafolder.This means that all fixtures in files called
default.ts-fixturereplaceeach other as they are found and vie to be the last
default.ts-fixturestanding in the
rosettafolder. This causes unintended compiliationfailures for
yarn rosetta:extract --compilein projects that rely onubergen, since they will be copied into the wrong
default.ts-fixture.The solution here in jsii is to find fixtures based on submodules: aws/jsii#3131.
This PR updates ubergen to construct the necessary subfolders in
rosettaso that the expected submodule fixtures can be found.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license